fix: ignore drag & drop from unrelated events #1968 #2346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements a fix for #1968 to ignore drag & drop events for completely unrelated events on the page.
I tested with this:
Rationale
If an event is not from the current blocknote editor, or coming from another blocknote editor on the page, we should not be capturing that event.
Changes
Impact
It could have impact on drag & drop behavior, manual testing was done to make sure blocknote drag & drop worked as expected.
Testing
Manual testing, given the complexity of adding e2e tests for drag & drop behaviors
Screenshots/Video
Checklist
Additional Notes
Thanks to @roNn23 for pointing out this fix